[ 
https://issues.apache.org/jira/browse/SOLR-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yonik Seeley updated SOLR-1270:
-------------------------------

    Attachment: SOLR-1270.patch

I agree we should strive to generate valid transfer syntax, and that is 
probably more important than maintaining the correct (float) type since that is 
at a higher level.

The plain numeric types were really meant for back compatibility with existing 
Lucene indexes being read by Solr - so trying to normalize during indexing (in 
Solr) won't solve all of the problems.  Once the new numeric types in Solr (the 
Trie based ones) get full support, these plain types should *only* be used for 
back compatibility with older indexes.

What do people thing about the attached patch?  It tries to always return valid 
transfer syntax, and not to destroy information, at the cost of not always 
returning a float type.

> The FloatField (and probably others) field type takes any string value at 
> index, but JSON writer outputs as numeric without checking
> ------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-1270
>                 URL: https://issues.apache.org/jira/browse/SOLR-1270
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 1.2, 1.3, 1.4
>         Environment: ubuntu 8.04, sun java 6, tomcat 5.5
>            Reporter: Donovan Jimenez
>            Priority: Minor
>         Attachments: SOLR-1270.patch
>
>
> The FloatField field type takes any string value at index. These values 
> aren't necessarily in JSON numeric, but the JSON writer does not check its 
> validity before writing it out as a JSON numeric.
> I'm aware of the SortableFloatField which does do index time verification and 
> conversion of the value, but the way the JSON writer is working seemed like 
> either a bug that needed addressed or perhaps a gotch that needs better 
> documented?
> This issue originally came from my php client issue tracker: 
> http://code.google.com/p/solr-php-client/issues/detail?id=13

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to