[ 
https://issues.apache.org/jira/browse/SOLR-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739152#action_12739152
 ] 

Donovan Jimenez commented on SOLR-1270:
---------------------------------------

Yonik has already started standardizing output time checking. So keep going 
there and we're good.

The trunk example schema now uses Trie fields for the default numeric types 
with precisionStep of 0. This should be fine since this seems to be the 
preferred / suggested field type implementations. The main idea of our argument 
was that the default make sense for the new user - I believe that change 
accomplishes this.  So again, we're good.

I also see new comments about which example field types are considered legacy - 
 good. The Trie field also mentions a little about how it generates tokens 
which can help when examining the index with tools like luke - a point of 
confusion that matt mentioned - so again, good.  The sortable numeric 
definitions might benefit from similar info in the comments. Probably the only 
thing I could offer as a suggestion.

Personally, I think you could remove more of the unused configuration from the 
example, but that's subjective opinion - some people like adding to a minimum, 
others like to prune from a maximum. I think that solr as a community is of the 
"let them prune" persuasion.


> Legacy Numeric Field types need to be more consistent in their input/output 
> error checking & documentation
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-1270
>                 URL: https://issues.apache.org/jira/browse/SOLR-1270
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 1.2, 1.3, 1.4
>         Environment: ubuntu 8.04, sun java 6, tomcat 5.5
>            Reporter: Donovan Jimenez
>            Assignee: Yonik Seeley
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-1270.patch
>
>
> FloatField, IntField, ByteField, LongField. and DoubleField have inconsistent 
> behavior at response writing time when dealing with "garbage" data in the 
> index.  the behavior should be standardized, and better documented.
> --
> This issue originally came from my php client issue tracker: 
> http://code.google.com/p/solr-php-client/issues/detail?id=13

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to