[ 
https://issues.apache.org/jira/browse/SOLR-1099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740152#action_12740152
 ] 

Yonik Seeley commented on SOLR-1099:
------------------------------------

Finally got around to reviewing the interface for some of this stuff...
there are a number of oddities (things like using the complete text of a field 
as the key or name in a map value, listing the value twice, requiring a 
uniqueKey)... but then I started thinking about who will use this, and maybe 
it's not worth trying to fix it up right now.

And that got me thinking why there are SolrJ classes dedicated to it... and I'm 
not sure that we should take up space for that.

IMO, common things in SolrJ should have easier, more type safe interfaces and 
uncommon, advanced features should be accessed via the generic APIs in order to 
keep the interfaces smaller and more understandable for the general user.

> FieldAnalysisRequestHandler
> ---------------------------
>
>                 Key: SOLR-1099
>                 URL: https://issues.apache.org/jira/browse/SOLR-1099
>             Project: Solr
>          Issue Type: New Feature
>          Components: Analysis
>    Affects Versions: 1.3
>            Reporter: Uri Boness
>            Assignee: Shalin Shekhar Mangar
>             Fix For: 1.4
>
>         Attachments: AnalisysRequestHandler_refactored.patch, 
> analysis_request_handlers_incl_solrj.patch, 
> AnalysisRequestHandler_refactored1.patch, 
> FieldAnalysisRequestHandler_incl_test.patch, SOLR-1099.patch, 
> SOLR-1099.patch, SOLR-1099.patch
>
>
> The FieldAnalysisRequestHandler provides the analysis functionality of the 
> web admin page as a service. This handler accepts a filetype/fieldname 
> parameter and a value and as a response returns a breakdown of the analysis 
> process. It is also possible to send a query value which will use the 
> configured query analyzer as well as a showmatch parameter which will then 
> mark every matched token as a match.
> If this handler is added to the code base, I also recommend to rename the 
> current AnalysisRequestHandler to DocumentAnalysisRequestHandler and have 
> them both inherit from one AnalysisRequestHandlerBase class which provides 
> the common functionality of the analysis breakdown and its translation to 
> named lists. This will also enhance the current AnalysisRequestHandler which 
> right now is fairly simplistic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to