[
https://issues.apache.org/jira/browse/SOLR-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745013#action_12745013
]
Grant Ingersoll commented on SOLR-1367:
---------------------------------------
bq. That said, docListToSolrDocList isn't even used in Solr anywhere, so I
don't care too much - it can be deprecated/removed later. Solr itself shouldn't
use this method since it's not streamable. Allowing custom modifications while
preserving streamability does call for callbacks... but not in 1.4
Right, it is likely used by a very small subset of people who: write their own
SearchComp and modify the doclist. LocalSolr is one such case. If you look at
PJ's patch on SOLR-773, you will see it in use. I think Ryan put it in, so he
may have use case for it too. It is _definitely_ not needed by Solr itself.
The modifier thing is also likely a temp fix until pseudo-fields and pluggable
doc stores are in place.
> Provide Callback mechanism for SolrPluginUtils.docListToSolrDocumentList
> ------------------------------------------------------------------------
>
> Key: SOLR-1367
> URL: https://issues.apache.org/jira/browse/SOLR-1367
> Project: Solr
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-1367.patch
>
>
> Sometimes SearchComponents need to modify the DocList. Often times this
> requires two loops over the (Solr)DocList: once to convert the DocList to
> SolrDocList and then once to iterate the SolrDocList for the Search
> Component. This can be seen in SOLR-773, for example.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
