[
https://issues.apache.org/jira/browse/SOLR-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747933#action_12747933
]
Grant Ingersoll commented on SOLR-1143:
---------------------------------------
I don't follow. The only difference between the two methods is that
takeOrError returns immediately if there was an error and doesn't put it in the
response list, which is what you are checking for in your loop anyway. From
what I can tell the while loop isn't going to break until all pending are
accounted for, either by error or by valid results. I don't see how it is
beneficial to examine every shard response every time and I don't see why that
would prevent you from losing responses as it is independent of the request
sent.
> Return partial results when a connection to a shard is refused
> --------------------------------------------------------------
>
> Key: SOLR-1143
> URL: https://issues.apache.org/jira/browse/SOLR-1143
> Project: Solr
> Issue Type: Improvement
> Components: search
> Reporter: Nicolas Dessaigne
> Assignee: Grant Ingersoll
> Fix For: 1.4
>
> Attachments: SOLR-1143-2.patch, SOLR-1143-3.patch, SOLR-1143.patch
>
>
> If any shard is down in a distributed search, a ConnectException it thrown.
> Here's a little patch that change this behaviour: if we can't connect to a
> shard (ConnectException), we get partial results from the active shards. As
> for TimeOut parameter (https://issues.apache.org/jira/browse/SOLR-502), we
> set the parameter "partialResults" at true.
> This patch also adresses a problem expressed in the mailing list about a year
> ago
> (http://www.nabble.com/partialResults,-distributed-search---SOLR-502-td19002610.html)
> We have a use case that needs this behaviour and we would like to know your
> thougths about such a behaviour? Should it be the default behaviour for
> distributed search?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
