[
https://issues.apache.org/jira/browse/SOLR-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shalin Shekhar Mangar updated SOLR-1406:
----------------------------------------
Attachment: SOLR-1406.patch
# Made FileDataSource and FileListEntityProcessor more extensible.
# I also found that biggerThan and smallerThan were two parameters in
FileListEntityProcessor which were never being set. I've fixed that.
I have not exposed FileListEntityProcessor's getFolderFiles method because I'd
prefer to keep the implementation private for now so that we can change it in
future without worrying about back-compat (see SOLR-1313). However, if one
wants to know the file names being processed, one can override
EntityProcessorBase#getNext.
Luke, does this help in your use-case?
> Refactor FileDataSource and FileListEntityProcessor to be more extensible
> -------------------------------------------------------------------------
>
> Key: SOLR-1406
> URL: https://issues.apache.org/jira/browse/SOLR-1406
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 1.4
> Reporter: Luke Forehand
> Assignee: Noble Paul
> Attachments: SOLR-1406.patch, SOLR-1406.patch
>
>
> FileDataSource should make openStream method protected so we can extend
> FileDataSource for other File types such as GZip, by controlling the
> underlying InputStreamReader implementation being returned.
> FileListEntityProcessor needs to aggregate a list of files that were
> processed and expose that list in an accessible way so that further
> processing on that file list can be done in the close method. For example,
> deletion or archiving.
> Another improvement would be that in the event of an indexing rollback event,
> processing of the close method either does not occur, or the close method is
> allowed access to that event, to prevent processing within the close method
> if necessary.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
