[ 
https://issues.apache.org/jira/browse/SOLR-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752268#action_12752268
 ] 

Yonik Seeley commented on SOLR-1071:
------------------------------------

I'm moving forward with the most straightforward fix... the string becomes a 
map for extended results.  So
<str>dell</str> in non extended results because the following in extended 
results:
<lst>  <str name="word">dell</str> <int name="freq">1</int> </lst>

So voice your objections now ;-)

Actually, the code to do the change is already done... the hard part is the 
tests... and there seems to be no unit tests for the SolrJ part that actually 
test the Suggestion class.

> spellcheck.extendedResults returns an invalid JSON response when count > 1
> --------------------------------------------------------------------------
>
>                 Key: SOLR-1071
>                 URL: https://issues.apache.org/jira/browse/SOLR-1071
>             Project: Solr
>          Issue Type: Bug
>          Components: spellchecker
>    Affects Versions: 1.3
>            Reporter: Uri Boness
>            Assignee: Yonik Seeley
>             Fix For: 1.4
>
>         Attachments: SpellCheckComponent_fix.patch, 
> SpellCheckComponent_new_structure.patch, 
> SpellCheckComponent_new_structure_incl_test.patch
>
>
> When: wt=json & spellcheck.extendedResults=true & spellcheck.count > 1, the 
> suggestions are returned in the following format:
> "suggestions":[
>       "amsterdm",{
>        "numFound":5,
>        "startOffset":0,
>        "endOffset":8,
>        "origFreq":0,
>        "suggestion":{
>         "frequency":8498,
>         "word":"amsterdam"},
>        "suggestion":{
>         "frequency":1,
>         "word":"amsterd"},
>        "suggestion":{
>         "frequency":8,
>         "word":"amsterdams"},
>        "suggestion":{
>         "frequency":1,
>         "word":"amstedam"},
>        "suggestion":{
>         "frequency":22,
>         "word":"amsterdamse"}},
>       "beak",{
>        "numFound":5,
>        "startOffset":9,
>        "endOffset":13,
>        "origFreq":0,
>        "suggestion":{
>         "frequency":379,
>         "word":"beek"},
>        "suggestion":{
>         "frequency":26,
>         "word":"beau"},
>        "suggestion":{
>         "frequency":26,
>         "word":"baak"},
>        "suggestion":{
>         "frequency":15,
>         "word":"teak"},
>        "suggestion":{
>         "frequency":11,
>         "word":"beuk"}},
>       "correctlySpelled",false,
>       "collation","amsterdam beek"]}}
> This is an invalid json as each term is associated with a JSON object which 
> holds multiple "suggestion" attributes. When working with a JSON library only 
> the last "suggestion" attribute is picked up.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to