[
https://issues.apache.org/jira/browse/SOLR-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753668#action_12753668
]
Mark Miller commented on SOLR-1221:
-----------------------------------
bq. the only oddity is the name of the testPhraseHighlighter now tests the
non-phrase highlighter.
Okay, will address.
bq. Also, testing wise, do we now risk losing tests for the other highlighter?
Yeah - before the phrase highlighter was "undertested" and the default had
more, and now
its the reverse. I suppose ideally, every test would hit both - that gets ugly
though - its what
we do in Lucene. Thats why I am confident in the tests I suppose though -
Lucene runs
both through every test - so the PhraseHighlighter matches the other
highlighters functionality
and adds support for more query types. I think between Lucene and Solr, the
tests are sufficient -
but I couldn't argue against more coverage here - hard to argue against testing
in any form :)
> Change Solr Highlighting to use the SpanScorer with MultiTerm expansion by
> default
> ----------------------------------------------------------------------------------
>
> Key: SOLR-1221
> URL: https://issues.apache.org/jira/browse/SOLR-1221
> Project: Solr
> Issue Type: Improvement
> Components: highlighter
> Reporter: Mark Miller
> Assignee: Mark Miller
> Fix For: 1.4
>
> Attachments: SOLR-1221.patch
>
>
> To improve the out of the box experience of Solr 1.4, I really think we
> should make this change. You will still be able to turn both off.
> Comments?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
