[ 
https://issues.apache.org/jira/browse/SOLR-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761949#action_12761949
 ] 

Mark Miller commented on SOLR-1319:
-----------------------------------

Right - I don't think its a big deal either. But the Highlighter framework has 
things like protected methods that are not overridden internally - seems to 
suggest that users could/might override them - whether we know they do or not, 
I think thats worth a mention in Changes on the break. Certainly easy enough to 
do anyway.

The break itself is even less likely to be an issue than a custom highlighter 
in general - I like the completeness myself though. Its an extendable public 
class and Solr allows for plugins.

> Upgrade custom Solr Highlighter classes to new Lucene Highlighter API
> ---------------------------------------------------------------------
>
>                 Key: SOLR-1319
>                 URL: https://issues.apache.org/jira/browse/SOLR-1319
>             Project: Solr
>          Issue Type: Task
>          Components: highlighter
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: 1.4
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to