A bit of a shame if the HTML stripper in 1.4 will be useless for most real situations.
I have added a new version of the patch, with test cases for the stuff that I am fixing. I also think that the new code is a bit easier to follow (no longer reusing existing state variables), so hopefully it will be even easier to review. Anders. Yonik Seeley <yo...@lucidimagination.com> writes: > Unfortunately we don't have good unit tests for this, so it's > difficult for people to tell if we've avoided regressions while making > progress. > > But since it's a bug fix... it is technically possible for it to be > included after the code freeze deadline I think? > > -Yonik > > On Fri, Oct 9, 2009 at 5:20 PM, Anders Melchiorsen > <m...@spoon.kalibalik.dk> wrote: >> Yonik Seeley <yo...@lucidimagination.com> writes: >> >>> One further issue... should we commit the changes to the HTMLStripReader? >>> https://issues.apache.org/jira/browse/SOLR-1394 >> >> As the reporter of that bug, I would obviously like to see a fix >> included in 1.4. >> >> It would be one thing to have the patch declared faulty, but having it >> miss the window due to being ignored bothers me a bit. >> >> Is there anything that I can do to help it along? >> >> Anders.
