[ https://issues.apache.org/jira/browse/SOLR-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770987#action_12770987 ]
Hoss Man commented on SOLR-1529: -------------------------------- I'm not at a machine where i can try to reproduce this, but i want to try and understand the severity ... looking at LogUPdateProcessorFactory via viewvc, I believe what this bug is reporting is that if a single request includes more then 8 (maxNumToLog) deleteByQuery directives, w/o including any deleteById directives, then the logger will generate an NPE. (regardless of how many docs were deleted) Which means something like this would probably be a way to recreate it in the example... {noformat} java -Ddata=args -jar post.jar "<delete><query>X</query><query>X</query><query>X</query><query>X</query><query>X</query><query>X</query><query>X</query><query>X</query><query>X</query></delete>" {noformat} ... and adding a single <id> entry (even if bogus, or possibly blank) would work arround the problem.... {noformat} java -Ddata=args -jar post.jar "<delete><query>X</query><query>X</query><query>X</query><query>X</query><query>X</query><query>X</query><query>X</query><query>X</query><query>X</query><id /></delete>" java -Ddata=args -jar post.jar "<delete><query>X</query><query>X</query><query>X</query><query>X</query><query>X</query><query>X</query><query>X</query><query>X</query><query>X</query><id>NOT_A_REAL_ID</id></delete>" {noformat} ...is that all correct? Questions should influence whether we consider this a show stopper for 1.4... * Does the update succeed in spite of the NPE, or does the entire update fail? * Is this bug new in 1.4, or will it also occur in 1.3 (skimming viewvc for the 1.3 tag it looks like this bug has been around for a while) > NullPointerException in LogUpdateProcessorFactory.java when deleting by query > *only* > ------------------------------------------------------------------------------------ > > Key: SOLR-1529 > URL: https://issues.apache.org/jira/browse/SOLR-1529 > Project: Solr > Issue Type: Bug > Affects Versions: 1.4 > Reporter: Asmodean > Fix For: 1.5 > > Attachments: logger.patch > > > The problem occurs when a RequestUpdate has deletions that are all *byQuery > (as opposed to *byId). The variable 'deletes' is in this case never > initialized and will cause a NullPointerException in some cases (where the > number of deletions are high enough). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.