[
https://issues.apache.org/jira/browse/SOLR-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778360#action_12778360
]
Chris A. Mattmann commented on SOLR-1516:
-----------------------------------------
bq. I am looking at the patch and find it difficult to see the value this
brings.
Can you elaborate on why you don't think this patch adds value? I've elaborated
above on the value I think that this brings, and I would appreciate the same
level of detail regarding the contrary.
I'm +1 for actually refactoring and rewriting the QueryResponseWriter
framework, making all QueryResponseWriters use an abstract base class, and
functions/methods around this, simplifying the code. Furthermore, I'm also for
getting rid of the abstract data structure (bag of objects) class called
NamedValueList and replacing it with a more concrete type hierarchy, but I
think that's another patch (or series of patches) IMHO. Furthermore, there is
one succinct difference between this patch and any GenericResponseWriter that
you are proposing, namely: the existing SOLR QueryResponseWriters are all means
of hijacking the _entire_ SOLR QueryResponse and writing it out in a particular
format. On the other hand, my patch is focused on allowing the user to hijack
simply the returned DocumentList (full set), or hijack the response on a
Doc-by-Doc basis.
> DocumentList and Document QueryResponseWriter
> ---------------------------------------------
>
> Key: SOLR-1516
> URL: https://issues.apache.org/jira/browse/SOLR-1516
> Project: Solr
> Issue Type: New Feature
> Components: search
> Affects Versions: 1.3
> Environment: My MacBook Pro laptop.
> Reporter: Chris A. Mattmann
> Assignee: Noble Paul
> Priority: Minor
> Fix For: 1.5
>
> Attachments: SOLR-1516.Mattmann.101809.patch.txt
>
>
> I tried to implement a custom QueryResponseWriter the other day and was
> amazed at the level of unmarshalling and weeding through objects that was
> necessary just to format the output o.a.l.Document list. As a user, I wanted
> to be able to implement either 2 functions:
> * process a document at a time, and format it (for speed/efficiency)
> * process all the documents at once, and format them (in case an aggregate
> calculation is necessary for outputting)
> So, I've decided to contribute 2 simple classes that I think are sufficiently
> generic and reusable. The first is o.a.s.request.DocumentResponseWriter -- it
> handles the first bullet above. The second is
> o.a.s.request.DocumentListResponseWriter. Both are abstract base classes and
> require the user to implement either an #emitDoc function (in the case of
> bullet 1), or an #emitDocList function (in the case of bullet 2). Both
> classes provide an #emitHeader and #emitFooter function set that handles
> formatting and output before the Document list is processed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
