[ 
https://issues.apache.org/jira/browse/SOLR-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779699#action_12779699
 ] 

Hoss Man commented on SOLR-1570:
--------------------------------

Lance: i wasn't suggesting that we required unieuqKey to be indexed, and 
shalin's patch doesn't do this ... my concern is merely that we log a an error 
-- if you know what you're doing and want to ignore that erorr then that's 
totally your choice.

I'm curious however: the only purpose for having a uniqueKey field in solr is 
the deduping and delete by id ... if you don't make your uniqueKey field 
indexed, then neither of those things are possible, so why bother using the 
<uniqueKey> declaration at all? ... you can still have an 'id" field without 
using  <uniqueKey>, so maybe we should require uniqueKey to be indexed?

Shalin: your patch looks good to me, except that it doesn't warn about the 
indexed=false case.

> Complain loudly if uniqueKey field is definied but not 
> indexed=true,stored=true,multiValued=false
> -------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-1570
>                 URL: https://issues.apache.org/jira/browse/SOLR-1570
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hoss Man
>         Attachments: SOLR-1570.patch
>
>
> When loading a new schema, Solr should log some "SEVERE" warnings if the 
> schema uses a uniqueKey field, but that field/type don't match the expected 
> needs of unieuqKey field for most functionality to work (indexed=true, 
> stored=true, multiValued=false) ... that way people won't (have any reason 
> to) be suprised when things break later)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to