[ https://issues.apache.org/jira/browse/SOLR-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781267#action_12781267 ]
Yonik Seeley commented on SOLR-1589: ------------------------------------ This only makes sense if callers can catch the exception and handle it differently than they would other exceptions (I could see this possibly being used in the future though). If there's a specific type of exception (like FieldValidationException) then a specific error code isn't needed - 400 will do. We would need to map to a standard HTTP error code before passing it back to the client anyway. > Make FieldType#toInternal throw explicit Exceptions when Field values don't > validate > ------------------------------------------------------------------------------------ > > Key: SOLR-1589 > URL: https://issues.apache.org/jira/browse/SOLR-1589 > Project: Solr > Issue Type: Improvement > Affects Versions: 1.4 > Environment: My MacBook pro laptop. > Reporter: Chris A. Mattmann > Priority: Minor > Fix For: 1.5 > > > As discussed on the mailing list: > http://mail-archives.apache.org/mod_mbox/lucene-solr-dev/200911.mbox/%3c85641490-9e70-41b3-a32e-22935b688...@apache.org%3e > I think we can do a better job of having explicit Exceptions when there is a > problem creating the internal representation of a Field, as defined by > FieldType#toInternal. Instead of throwing obscure RuntimeExceptions, let's > create a FieldValidationException explicit type, and make > o.a.solr.schema.FieldType#toInternal throw this Exception as part of its > signature. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.