[
https://issues.apache.org/jira/browse/SOLR-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788121#action_12788121
]
Grant Ingersoll commented on SOLR-1131:
---------------------------------------
bq. IMO, unit tests can be too low level. They can also be too fragile.
I guess it all comes down to what you call a unit.
bq. t would be nice, for example, if testPointFieldType indexed a few couments
(with various combinations of stored / indexed) and then queried the index,
This is done in testIndexing()
bq. TopDocs topDocs = core.getSearcher().get().search(bq, 1);
Yeah, see my comment there even! I wanted a way to validate that the correct
query is created, but I don't even really need to run a search for that.
{quote}
Rendundant null checks, trivial strings, etc:
+ assertNotNull("topDocs is null", topDocs);
+ assertTrue(topDocs.totalHits + " does not equal: " + 1, topDocs.totalHits ==
1)
{quote}
I need to update my IntelliJ "Live Templates", as I have them setup to spit out
a pattern like above
bq. Please see the DocumentBuilder changes I had added...
Will do.
{quote}
Seems like SolrQueryParser should use getFieldQuery for everything (except
TextField... but it could even be used for that if we make it such that we
could call back to getBooleanQuery, etc). I had this in my patch.
{quote}
I thought I captured that, but will look again.
> Allow a single field type to index multiple fields
> --------------------------------------------------
>
> Key: SOLR-1131
> URL: https://issues.apache.org/jira/browse/SOLR-1131
> Project: Solr
> Issue Type: New Feature
> Components: Schema and Analysis
> Reporter: Ryan McKinley
> Assignee: Grant Ingersoll
> Fix For: 1.5
>
> Attachments: SOLR-1131-IndexMultipleFields.patch, SOLR-1131.patch,
> SOLR-1131.patch, SOLR-1131.patch, SOLR-1131.patch, SOLR-1131.patch
>
>
> In a few special cases, it makes sense for a single "field" (the concept) to
> be indexed as a set of Fields (lucene Field). Consider SOLR-773. The
> concept "point" may be best indexed in a variety of ways:
> * geohash (sincle lucene field)
> * lat field, lon field (two double fields)
> * cartesian tiers (a series of fields with tokens to say if it exists within
> that region)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
