[
https://issues.apache.org/jira/browse/SOLR-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788913#action_12788913
]
Andrzej Bialecki commented on SOLR-1316:
-----------------------------------------
Thanks for the review!
bq. Why do we concatenate all the tokens into one before calling
Lookup#lookup? It seems we should be getting suggestions for each token just as
SpellCheckComponent does.
Yeah, it's disputable, and we could change it to use single tokens ... My
thinking was that the usual scenario is that you submit autosuggest queries
soon after user starts typing the query, and the highest perceived value of
such functionality is when it can suggest complete meaningful phrases and not
just individual terms. I.e. when you start typing "token sug" it won't suggest
"token sugar" but instead it will suggest "token suggestions".
bq. Related to #1, the Lookup#lookup method should return something more fine
grained rather than a SpellingResult
Such as? What you put there is what you get ;) so the fact that we are getting
complete phrases as suggestions is the consequence of the choice above - the
trie in this case is populated with phrases. If we populate it with tokens,
then we can return per-token suggestions, again - losing the added value I
mentioned above.
bq. Has anyone done any benchmarking to figure out the data structure we want
to go ahead with?
For now I'm sure that we do NOT want to use the impl. of RadixTree in this
patch, because it doesn't support our use case - I'll prepare a patch that
removes this impl. Other implementations seem comparable wrt. to the speed,
based on casual tests using /usr/share/dict/words, but I didn't run any exact
benchmarks yet.
> Create autosuggest component
> ----------------------------
>
> Key: SOLR-1316
> URL: https://issues.apache.org/jira/browse/SOLR-1316
> Project: Solr
> Issue Type: New Feature
> Components: search
> Affects Versions: 1.4
> Reporter: Jason Rutherglen
> Assignee: Shalin Shekhar Mangar
> Priority: Minor
> Fix For: 1.5
>
> Attachments: suggest.patch, suggest.patch, TST.zip
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> Autosuggest is a common search function that can be integrated
> into Solr as a SearchComponent. Our first implementation will
> use the TernaryTree found in Lucene contrib.
> * Enable creation of the dictionary from the index or via Solr's
> RPC mechanism
> * What types of parameters and settings are desirable?
> * Hopefully in the future we can include user click through
> rates to boost those terms/phrases higher
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
