[ 
https://issues.apache.org/jira/browse/SOLR-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789484#action_12789484
 ] 

Chris A. Mattmann edited comment on SOLR-1131 at 12/11/09 7:39 PM:
-------------------------------------------------------------------

Hi All,

Updated patch:

{quote}
# Introduced a MultiValueSource - ValueSource that abstractly represents 
ValueSources for poly fields, and other things.
{quote}

I added javadoc to this and the ASF license header.

{quote}
# Introduced PointValueSource - point(x,y,z) - a MultiValueSource that wraps 
other value sources (could be called something else, I suppose)
{quote}

I put the ASF header before the package decl, to be consistent with the other 
SOLR java files.

{quote}
# Add in SchemaAware callback mechanism so that Field Types and other schema 
stuff can register dynamic fields, etc. after the schema has been created
{quote}

Added more javadoc here, and ASF license.

{quote}
# Incorporated various comments from Chris and Yonik.
{quote}

Thanks, I appreciate it. I'm still -1 on the way this patch deals with the 
"optimization" issue. I'd like to see evidence that it makes sense to not use 
split and trim.

Cheers,
Chris



      was (Author: chrismattmann):
    OK, this is getting a lot closer to ready to commit.

Changes:
Hi All,

Updated patch:

{quote}
# Introduced a MultiValueSource - ValueSource that abstractly represents 
ValueSources for poly fields, and other things.
{quote}

I added javadoc to this and the ASF license header.

{quote}
# Introduced PointValueSource - point(x,y,z) - a MultiValueSource that wraps 
other value sources (could be called something else, I suppose)
{quote}

I put the ASF header before the package decl, to be consistent with the other 
SOLR java files.

{quote}
# Add in SchemaAware callback mechanism so that Field Types and other schema 
stuff can register dynamic fields, etc. after the schema has been created
{quote}

Added more javadoc here, and ASF license.

{quote}
# Incorporated various comments from Chris and Yonik.
{quote}

Thanks, I appreciate it. I'm still -1 on the way this patch deals with the 
"optimization" issue. I'd like to see evidence that it makes sense to not use 
split and trim.

Cheers,
Chris


  
> Allow a single field type to index multiple fields
> --------------------------------------------------
>
>                 Key: SOLR-1131
>                 URL: https://issues.apache.org/jira/browse/SOLR-1131
>             Project: Solr
>          Issue Type: New Feature
>          Components: Schema and Analysis
>            Reporter: Ryan McKinley
>            Assignee: Grant Ingersoll
>             Fix For: 1.5
>
>         Attachments: SOLR-1131-IndexMultipleFields.patch, 
> SOLR-1131.Mattmann.121009.patch.txt, SOLR-1131.Mattmann.121109.patch.txt, 
> SOLR-1131.patch, SOLR-1131.patch, SOLR-1131.patch, SOLR-1131.patch, 
> SOLR-1131.patch, SOLR-1131.patch, SOLR-1131.patch
>
>
> In a few special cases, it makes sense for a single "field" (the concept) to 
> be indexed as a set of Fields (lucene Field).  Consider SOLR-773.  The 
> concept "point" may be best indexed in a variety of ways:
>  * geohash (sincle lucene field)
>  * lat field, lon field (two double fields)
>  * cartesian tiers (a series of fields with tokens to say if it exists within 
> that region)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to