[
https://issues.apache.org/jira/browse/SOLR-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789745#action_12789745
]
Yonik Seeley commented on SOLR-1644:
------------------------------------
While we should make it easy for custom components to store their own flags +
state, etc, we should be careful about hiding the state of well known
components. It's OK to hide internal implementation stuff, but we should leave
anything useful to other components exposed (and more explicitly spell out what
it means, if it can be changed by another component, etc).
Whether a request is a faceting request or not could certainly be useful to
other components... and as a bonus it eliminates a hash lookup for each
component each time through the loop.
> Provide a clean way to keep flags and helper objects in ResponseBuilder
> -----------------------------------------------------------------------
>
> Key: SOLR-1644
> URL: https://issues.apache.org/jira/browse/SOLR-1644
> Project: Solr
> Issue Type: Improvement
> Components: search
> Reporter: Shalin Shekhar Mangar
> Assignee: Shalin Shekhar Mangar
> Fix For: 1.5
>
> Attachments: SOLR-1644.patch
>
>
> Many components such as StatsComponent, FacetComponent etc keep flags and
> helper objects in ResponseBuilder. Having to modify the ResponseBuilder for
> such things is a very kludgy solution.
> Let us provide a clean way for components to keep arbitrary objects for the
> duration of a (distributed) search request.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
