[
https://issues.apache.org/jira/browse/SOLR-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12792930#action_12792930
]
Robert Muir commented on SOLR-1670:
-----------------------------------
bq. Why don't you fix the flaws in SynonymFilter test in this ticket first,
then fix SOLR-1674? (I've not looked into SOLR-1674 yet.)
Because how would you know I properly fixed it? In fact, if anyone else
submitted a patch to fix this issue, I don't really care how many tests they
write, I would post a comment voting against the patch, because the tests mean
nothing.
The analysis tests themselves (things like this assertTokEqual) are broken, so
SOLR-1674 fixes the analysis tests so they actually work.
I think we have to make the tests work correctly, before we can think of fixing
nontrivial bugs?
> synonymfilter/map repeat bug
> ----------------------------
>
> Key: SOLR-1670
> URL: https://issues.apache.org/jira/browse/SOLR-1670
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
> Affects Versions: 1.4
> Reporter: Robert Muir
> Attachments: SOLR-1670_test.patch
>
>
> as part of converting tests for SOLR-1657, I ran into a problem with
> synonymfilter
> the test for 'repeats' has a flaw, it uses this assertTokEqual construct
> which does not really validate that two lists of token are equal, it just
> stops at the shorted one.
> {code}
> // repeats
> map.add(strings("a b"), tokens("ab"), orig, merge);
> map.add(strings("a b"), tokens("ab"), orig, merge);
> assertTokEqual(getTokList(map,"a b",false), tokens("ab"));
> /* in reality the result from getTokList is ab ab ab!!!!! */
> {code}
> when converted to assertTokenStreamContents this problem surfaced. attached
> is an additional assertion to the existing testcase.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
