[
https://issues.apache.org/jira/browse/SOLR-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793646#action_12793646
]
Yonik Seeley commented on SOLR-1674:
------------------------------------
Hmmm, isn't it a bug that this passes?
assertTokenizesTo(map, "a b", new String[] { "ab", "ab", "ab" });
w/o the 1670 fix, we get "ab/ab/ab" (repeated tokens all at the same position).
That's not the same as three "ab" tokens in a row.
Also, we seem to have lost matching flexibility with overlapping tokens.
"a/aa" should be the same as "aa/a", but if you change the order of overlapping
tokens now, the tests fail.
Didn't ya guys like my a/aa syntax to indicate overlapping tokens? It
certainly made it faster for me to write the original testcases :-)
> improve analysis tests, cut over to new API
> -------------------------------------------
>
> Key: SOLR-1674
> URL: https://issues.apache.org/jira/browse/SOLR-1674
> Project: Solr
> Issue Type: Test
> Components: Schema and Analysis
> Reporter: Robert Muir
> Assignee: Mark Miller
> Attachments: SOLR-1674.patch, SOLR-1674.patch, SOLR-1674_speedup.patch
>
>
> This patch
> * converts all analysis tests to use the new tokenstream api
> * converts most tests to use the more stringent assertion mechanisms from
> lucene
> * adds new tests to improve coverage
> Most bugs found by more stringent testing have been fixed, with the exception
> of SynonymFilter.
> The problems with this filter are more serious, the previous tests were
> essentially a no-op.
> The new tests for SynonymFilter test the current behavior, but have FIXMEs
> with what I think the old test wanted to expect in the comments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
