[
https://issues.apache.org/jira/browse/SOLR-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794401#action_12794401
]
Mark Miller commented on SOLR-1647:
-----------------------------------
-1 on this patch.
1. There is no reason not to keep this for a release with a warning to users
that its going to be removed. You put in a deprecation tag in an earlier patch,
and now your just removing it before that was ever released - there is no
downside to doing this more like a *real* deprecation and there is upside.
2. You have put no warnings or information to users about this change - you
could be breaking things for some people and your doing it out of the blue - we
shouldn't pull the rug out from under users like that.
3. Ive I have said more than once, the current patch *breaks tests* that rely
on this feature.
I see no reason to remove it now. It should be deprecated with a warning in
changes about its impending removal. And you need to provide a workaround for
tests. I don't see why we don't just keep it for now. Its not hurting anything.
I'd also like to be more clear on what deprecation means in Solr - I know it
doesn't mean deprecating and removing before a release even goes out (that
makes no sense) - and I'm not sure if it means removing in the next dot release
(as Ive see that occurring recently). Can someone pipe in on whether Solr has
an (in)formal policy on when deprecations should/can be removed?
> Remove the option of setting solrconfig from web.xml
> ----------------------------------------------------
>
> Key: SOLR-1647
> URL: https://issues.apache.org/jira/browse/SOLR-1647
> Project: Solr
> Issue Type: Improvement
> Reporter: Noble Paul
> Assignee: Noble Paul
> Fix For: 1.5
>
> Attachments: SOLR-1647.patch
>
>
> with SOLR-1621 , it is not required to have an option to set solrconfig from
> web.xml. Moreover editing web.xml means hacking solr itself.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
