[ 
https://issues.apache.org/jira/browse/SOLR-1586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794699#action_12794699
 ] 

Chris A. Mattmann commented on SOLR-1586:
-----------------------------------------

bq. No it's not. It's package private. Is there something that isn't working?

Interesting. Eclipse was giving me an error on using StrFieldSource in 
GeoHashField, right on that line I pasted above. It said StrFieldSource not 
found, and so taking a look it looked like StrFieldSource was an inner class 
(hard to see that little "}" at the end and whether it was defined inside of 
StrField or not). So I thought you were referencing an inner (private) class 
from StrField external to it. Funny now though after an Eclipse rebuild, 
Eclispe seems to be OK with StrFieldSource and its referencing in GeoHashField 
(which it should since they are both in the same package).

Regardless though, this illustrates my point on SOLR-1688 -- these 
FieldCacheSources should be defined a bit more consistently -- when looking at 
a bunch of code, it's hard to see whether it was an inner class or a separate 
class defined in the same java file.

> Create Spatial Point FieldTypes
> -------------------------------
>
>                 Key: SOLR-1586
>                 URL: https://issues.apache.org/jira/browse/SOLR-1586
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>             Fix For: 1.5
>
>         Attachments: examplegeopointdoc.patch.txt, SOLR-1586-geohash.patch, 
> SOLR-1586.Mattmann.112209.geopointonly.patch.txt, 
> SOLR-1586.Mattmann.112209.geopointonly.patch.txt, 
> SOLR-1586.Mattmann.112409.geopointandgeohash.patch.txt, 
> SOLR-1586.Mattmann.112409.geopointandgeohash.patch.txt, 
> SOLR-1586.Mattmann.112509.geopointandgeohash.patch.txt, 
> SOLR-1586.Mattmann.120709.geohashonly.patch.txt, 
> SOLR-1586.Mattmann.121209.geohash.outarr.patch.txt, 
> SOLR-1586.Mattmann.121209.geohash.outstr.patch.txt, 
> SOLR-1586.Mattmann.122609.patch.txt, SOLR-1586.patch
>
>
> Per SOLR-773, create field types that hid the details of creating tiers, 
> geohash and lat/lon fields.
> Fields should take in lat/lon points in a single form, as in:
> <field name="foo">lat lon</field>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to