[ 
https://issues.apache.org/jira/browse/SOLR-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797004#action_12797004
 ] 

Kay Kay commented on SOLR-1212:
-------------------------------

@Shalin , @HossMan - I understand the pain of maintaining this one separate 
from Junit - but was concerned mostly about this being out of date with the 
tree. 

As regarding comparison between TestNG vs JUnit - one big advantage is to 
categorize the tests as different groups in testng and run them separately 
(especially useful as the code base of solr gets bigger + contrib ). Which is 
one of the primary reasons (After evaluating both ) - testng was chosen.  So  - 
if you guys are not comfortable with the patch - then (as shalin noted) - just 
make an entry in the wiki and leave this one as such. The code is definitely 
not big to warrant a sf project / github / google code at this point. 

A better patch would be to refactor existing JUnit Test case so that the testng 
version minimizes duplication as much as possible. 

> TestNG Test Case 
> -----------------
>
>                 Key: SOLR-1212
>                 URL: https://issues.apache.org/jira/browse/SOLR-1212
>             Project: Solr
>          Issue Type: New Feature
>          Components: clients - java
>    Affects Versions: 1.4
>         Environment: Java 6
>            Reporter: Kay Kay
>             Fix For: 1.5
>
>         Attachments: SOLR-1212.patch, testng-5.9-jdk15.jar
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> TestNG equivalent of AbstractSolrTestCase , without using JUnit altogether . 
> New Class created: AbstractSolrNGTest 
> LICENSE.txt , NOTICE.txt modified as appropriate. ( TestNG under Apache 
> License 2.0 ) 
> TestNG 5.9-jdk15 added to lib. 
> Justification:  In some workplaces - people are moving towards TestNG and 
> take out JUnit altogether from the classpath. Hence useful in those cases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to