[
https://issues.apache.org/jira/browse/SOLR-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12799787#action_12799787
]
Yonik Seeley commented on SOLR-1591:
------------------------------------
{quote}
But what about this?
if(map.get("foo")) != null writeAttr("foo", map.get("foo"));
if(map.get("bar")) != null writeAttr("bar", map.get("bar"));
{quote}
Why are you arguing performance if you're going to look up the key twice? It's
an order of magnitude more expensive.
This is such a trivial issue though... we really shouldn't be wasting breath on
it.
> XMLWriter#writeAttr silently ignores null attribute values
> ----------------------------------------------------------
>
> Key: SOLR-1591
> URL: https://issues.apache.org/jira/browse/SOLR-1591
> Project: Solr
> Issue Type: Bug
> Affects Versions: 1.1.0
> Environment: My local MacBook pro laptop.
> Reporter: Chris A. Mattmann
> Priority: Minor
> Attachments: SOLR-1591.Mattmann.112209.patch.txt
>
>
> XMLWriter#writeAttr checks for val == null, and if so, does nothing. Instead
> of doing nothing, it could leverage its method signature, and throw an
> IOException declaring that the value provided is null. Patch, attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
