[
https://issues.apache.org/jira/browse/SOLR-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846217#action_12846217
]
Hoss Man commented on SOLR-1817:
--------------------------------
Some rore comments now that i've read things a little more in depth...
* I should have read your comments more carefully, you already noted the
remaining usages of SolrConfig.severErrors
* two of the places you removed "adds" to SolrConfig.severErrors are in
IndexSchema, where exceptions are logged, but not thrown (so your new code
never sees them).
** Personally i think this is fine, because I don't think those two situations
really fit the definition of a "severe init error" as it was designed (ie: a
plugin like a request handler which might not be used in many situations can't
be initialized).
** I think errors in IndexSchema init should either be fatal (ie: thrown by the
constructor and prevent the core from ever working) or just logged as being
"bad news"
** FWIW, the two code places i'm talking about are...
*** when a field is declared twice
*** when a dynamicfield is declared twice
* why is "admin" suddenly a magic alias for "" in SolrDispatchFilter? (line 196)
* the big comment about servlet container behavior if you throw an error during
init doesn't make sense where you copied it (in doFilter, line 292)
> Fix Solr error reporting to work correctly with multicore
> ---------------------------------------------------------
>
> Key: SOLR-1817
> URL: https://issues.apache.org/jira/browse/SOLR-1817
> Project: Solr
> Issue Type: Bug
> Affects Versions: 1.4
> Reporter: Mark Miller
> Priority: Minor
> Fix For: 1.5
>
> Attachments: SOLR-1817.patch, SOLR-1817.patch, SOLR-1817.patch
>
>
> Here is a rough patch that attempts to fix how error reporting works with
> multi-core (not in terms of logs, but what you see on an http request).
> The patch is not done - more to consider and havn't worked with how this
> changes solrconfigs abortOnConfigurationError, but the basics are here.
> If you attempt to access the path of a core that could not load, you are
> shown the errors that kept the core from properly loading.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
