Hi Mat, Taking a quick look at your code via the gitHub browser (and not having downloaded or run it, that's for later! :) ), it looks _very_ clean, and well commented. Bravo!
If you get a chance and are interested in participating in the SOLR spatial effort, there are a few issues you could take a look at, in particular, based on what you have so far, I would take a look at SOLR-1568, having to do with creating a QParserPlugin for spatial: http://issues.apache.org/jira/browse/SOLR-1568 SOLR-773 tracks the general progress of all of the spatial work, here: http://issues.apache.org/jira/browse/SOLR-773 There is also a wiki page for the community efforts: http://wiki.apache.org/solr/SpatialSearch If you're not familiar with it yet, there has been a ton of work on Local SOLR and LocalLucene as well. You may want to check out those pages too, located here: http://www.gissearch.com/localsolr Again, bravo on such a clean, easy to understand plugin! I'll try and test out your code and provide some feedback if I get a chance soon. Also I welcome and encourage your contribution/discussion on the SOLR mailing lists and wiki area. Cheers, Chris On 12/30/09 3:51 PM, "Mat Brown" <m...@patch.com> wrote: > Hi all, > > I've been working on a small Solr plugin to expose the basic > functionality of lucene-spatial as unobtrusively as possible. I've got > a basic implementation up and passing tests, and I was hoping to get > some feedback on it. Though I've coded against Lucene for a production > app in the past, this is my first time writing code for Solr's plugin > API, so I could easily be entirely on the wrong track. > > Honest (even brutal!) feedback would be very much appreciated: > > http://github.com/outoftime/solr-spatial > > Thanks much, > Mat > > P.S. I definitely don't want to step on anyone's toes with the name - > if "solr-spatial" is already in use, or reserved for a future official > contrib for Solr, let me know and I'll come up with something else! > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Chris Mattmann, Ph.D. Senior Computer Scientist NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA Office: 171-266B, Mailstop: 171-246 Email: chris.mattm...@jpl.nasa.gov WWW: http://sunset.usc.edu/~mattmann/ ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Adjunct Assistant Professor, Computer Science Department University of Southern California, Los Angeles, CA 90089 USA ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
