John McNeil wrote: > Besides the problem mentioned above, your code doesn't properly handle > switching from a paused track to another one; play() will be called > first above before song_change() below, overwriting the data of the > old song before it can be posted.
Ah, thanks. I'm inclined to just apply your patch for now. I'll leave splitting it up into functions for someone to take care of later. > Additionally, play() doesn't just > set things up for posting when you first play a song, it does it every > time, so it np()s unnecessarily and can post with incorrect start > times. Very incorrect if you, for example, happen to pause near the > end of a song and then resume. And my complaint that it adds more code > for no real gain still stands Perhaps this is the only piece missing from your patch. Suppose I play, then pause the song, grab a cup of coffee and then come back and press play. My now playing on last.fm will be nothing because we only update now playing once. It seems that last.fm doesn't keep the now playing up for much longer than the actual length of the song sent. _______________________________________________ Sonata-users mailing list [email protected] https://lists.berlios.de/mailman/listinfo/sonata-users
