Hi Rémy, On Tue, Aug 30, 2011 at 10:16:25AM +0200, Rémy Hubscher wrote: > Hello guys, > ... > > You can follow patch overthere : https://bitbucket.org/natim/sonata
First of all, thanks for taking the time to make this patch! Originally, the project is hosted with Git, and there's also a Subversion repository on Codingteam, may I suggest you not to recreate another kind of repository? ;) > Appindicator Patch : > https://bitbucket.org/natim/sonata/changeset/db47d7d007c2/raw/ Last year, I refactored a bit how Sonata handles the tray icon and in articular, I removed all those "if HAVE_..." tests and proposed an unified interface to both egg.trayicon and gtk.StatusIcon. Basically, it abstracts (maybe in a very adequate way) the use of the tray icon by Sonata so that the main code doesn't bother to know if it deals with the egg extension or the built-in GTK thing. I suggest you have a look there: https://github.com/multani/sonata/commit/dc9427 I had a look at your patch, and it seems it can fit in the proposed unified tray interface, since AFAIK, the appindicator stuff replaces the tray icon (I'm not familiar with appindicator, so I may be wrong). So, I would strongly encourage you to rebase your patch on the work I did back then, I think it makes things clearer in the main code. > Cheers, > > Rémy Cheers, Jonathan _______________________________________________ Sonata-users mailing list [email protected] https://lists.berlios.de/mailman/listinfo/sonata-users
