> > >Log Message: > > >pciioctl(), pci_devioctl(): > > >simplify implementations of PCI_IOC_BDF_CFGREAD, PCI_IOC_BDF_CFGWRITE, > > >PCI_IOC_CFGREAD, PCI_IOC_CFGWRITE > > >No functional changes. : > I will try > > memset(&tag, 0, sizeof(tag)); > > in the default case and buildtest several kernel configs for different archs. > When this succeeds, I will commit.
I don't think it's a good idea to add a bogus statement for gcc to "simplify" implementation. It looks still better to move the PCI_IOC_BDF_CFGWRITE case and return ENOTTY for the default case into the first switch statement. --- Izumi Tsutsui
