On Tue Sep 08 2009 at 16:33:02 +0000, Christos Zoulas wrote: > In article <20090908162339.ga11...@cs.hut.fi>, > ntti Kantee <po...@cs.hut.fi> wrote: > > > >Whoever finds this churn worth their effort, as dh pointed out, remember > >to replace all instances of __FreeBSD__, __OpenBSD__, __Linux__, > >__Slowaris__, __sMackOS__, __etc__ as well. > > The issue here is that we really don't want to override the symbols set > by the compiler because a lot of code assumes that they are going to be > set by the compiler, and not by other external means. Everytime I remember > someone did this, it had to be reverted for one reason or the other.
Yes, I now realize it is the wrong thing to do (thank you). However, in its current form it only fixes things. It's not like rump on non-NetBSD is a fully supported concept. So for the time being, I think it is an acceptable path to take. Anything else, IMHO, is "premature optimization".
