> | > | As noted in the PR, the original problem is asnprintf() and > | > | vasnprinf() decls in src/include/heimdal/roken.h because > | > | Cygwin has the same functions with incompatible args > | > | (derived from GNU?) by default. > | > > | > This is unrelated to what I changed though and was not planning to look > | > into that. Grumble, I guess I will download cygwin 1.7.1 > | > | What I need is a review of my new patch :-) > | http://mail-index.NetBSD.org/netbsd-bugs/2010/01/21/msg015707.html > > Well, I'd prefer to avoid including a copy of roken.h for the tools.
The problem here is that src/include/heimdal/roken.h is a generated file and it's configured for NetBSD target and NetBSD host. Including it for tools on generic build hosts might be problematic. That's the reason why I added local roken.h for tools asn1_compile and compile_et in my patch. > I think that vasnprintf and asnprintf are not used by anything in > heimdal and can safely be removed. Combined with the winsize fix, > this fixes the cygwin problems with minimal changes. I am trying a > build now. Note roken.h includes <resolv.h> and <arpa/nameser.h> that don't exist on Cygwin so we had to handle it in src/tools/compat/configure. (toolchain/29032) --- Izumi Tsutsui