-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 2010-12-05 3:35 AM, Antti Kantee wrote: > On Sat Dec 04 2010 at 18:44:07 +0000, Christos Zoulas wrote: >> In article <20101204173951.3ae6e17...@cvs.netbsd.org>, >> Antti Kantee <source-changes-d@NetBSD.org> wrote: >>> -=-=-=-=-=- >>> >>> Module Name: src >>> Committed By: pooka >>> Date: Sat Dec 4 17:39:51 UTC 2010 >>> >>> Modified Files: >>> src/sys/dev: rnd.c >>> >>> Log Message: >>> Don't allow "goes to 11^H^Hhyperspace" len field for RNDADDATA. >>> >> >> Should be EINVAL; E2BIG has a very specific meaning (unless we want to change >> that). > > EINVAL is used too much and I try to pick more descriptive remotely > fitting errnos when possible. > > If someone feels strongly otherwise, please change it. >
E2BIG produces the odd message "argument list too long" -- my argument might be too long, but the list sure isn't. While I agree more details on the specific error might be nice, don't go deciding to just reuse existing ones. :) Please change it to EINVAL. - --Michael -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkz9DHkACgkQl6Nz7kJWYWYNJACfT2CoxQxfEQOvGjlhMw2ujSpD lyoAnRTvmn4DCUrzKzmWUbxtF+e3cWIa =Dsd6 -----END PGP SIGNATURE-----