On Tue Feb 08 2011 at 05:15:39 +0000, Christos Zoulas wrote: > In article <20110207124333.gg15...@cs.hut.fi>, > Antti Kantee <po...@netbsd.org> wrote: > >On Mon Feb 07 2011 at 11:51:02 +0000, Antti Kantee wrote: > >> Module Name: src > >> Committed By: pooka > >> Date: Mon Feb 7 11:51:02 UTC 2011 > >> > >> Modified Files: > >> src/lib/librumphijack: hijack.c > >> > >> Log Message: > >> Unbreak the ssp lossage from the default -current build by removing > >> it. I still don't have any idea what the ssp stuff is supposed to > >> do and how it's supposed to even begin to work. If someone wants > >> to change this now, run tests/lib/librumphijack before commit so > >> that I can avoid another multihour debugging session! > > > >In my debugging frenzy I thought that was the ssp stuff caused the > >problem, but in fact it didn't (it doesn't compile, so it cannot cause > >runtime problems). > > It used to compile and it seemed fine. Does it still?
I never understood what the ssp code was supposed to do and still don't. If read is changed to _hijack_read() 3rd party callers will not resolved here, and therefore the hijack lib does not do the one thing it is expected to do. -- älä karot toivorikkauttas, kyl rätei ja lumpui piisaa