On 25/04/2011 02:53, YAMAMOTO Takashi wrote:
hi,
Module Name: src
Committed By: sborrill
Date: Fri Apr 8 13:56:51 UTC 2011
Modified Files:
src/sys/dev/pci: if_alc.c if_bge.c
src/sys/net: if_vlan.c
Log Message:
PR kern/38871
Fix LAN on bge(4), alc(4). Flag VLAN capability in ec_capenable as used by
network
card drivers.
- who clears the flag?
>
> - probably it would be better to have separate flags for tx and rx.
> (i thought ETHERCAP_VLAN_HWTAGGING was for transmitting,
> but our tree seems inconsistent.)
I backed this out as it simply didn't work as it stood. Configuring the
vlan(4) interface set the flag in ec_capenable, but this flag was not
read again after bge_init() called bge_setvlan(). I tried calling
bge_setvlan() in bge_ioctl() (in a similar way to bge_setmulti()), but
bge_ioctl() wasn't called. So I bailed...
--
Stephen