On Mon, Aug 01, 2011 at 11:08:04AM +0000, Matthias Drochner wrote: > Module Name: src > Committed By: drochner > Date: Mon Aug 1 11:08:03 UTC 2011 > > Modified Files: > src/sys/arch/x86/include: pci_machdep_common.h > src/sys/arch/x86/pci: pci_intr_machdep.c > > Log Message: > add an experimental implementation of PCI MSIs (Message Signaled > Interrupts). Successfully tested with hdaudio and "wpi" wireless > ethernet. > notes:
Can you replace the magic numbers with symbols from pcireg.h ? You may need to add the symbols, of course. struct pci_attach_args * is const virtually everywhere, shouldn't it be a const argument to pci_msi_establish(), too? > -There seem to be buggy chips around which announce MSI support > but don't correctly implement it. Thus the final word whether MSIs > can be used should be by the driver. Might be helpful for other developers to see a heads-up about those chips. > -Drivers need to take care of saving/restoring MSI data in the device's > config space on suspend/resume. This may be the responsibility of pci_child_suspend()/pci_child_resume()? Dave -- David Young OJC Technologies dyo...@ojctech.com Urbana, IL * (217) 344-0444 x24
