On Thu, Aug 18, 2011 at 11:11:20AM -0700, Paul Goyette wrote: > >Module Name: src > >Committed By: christos > >Date: Thu Aug 18 17:02:49 UTC 2011 > > > >Modified Files: > > src/sys/modules/spdmem: Makefile > > > >Log Message: > >document non-literal string format > > Rather than sweeping the issue under the rug, wouldn't it be better to > actually fix the problem? > > See attached diff which replaces the "variable" format with a > literal #define string ...
I think we should make no changes to appease the compiler in this case. There is nothing inherently safer about using a literal format string than a static const format string, the compiler just isn't smart enough to tell an unsafe non-literal format string from a safe one. Dave -- David Young OJC Technologies dyo...@ojctech.com Urbana, IL * (217) 344-0444 x24