On Wed, Nov 30, 2011 at 01:13:10PM -0500, Christos Zoulas wrote: > On Nov 30, 12:13pm, bou...@antioche.eu.org (Manuel Bouyer) wrote: ... > Keeps the headers tidy, and it will make it easy in the future to delete > compatibility code. I would also move the compat code somewhere too, > and call a function around it: > > default: > #ifdef COMPAT_50 > error = fss_compat_ioctl(...); > #else > error = EINVAL; > #endif > } > > christos
I'd rather the .c file wasn't polluted with #ifdefs. Probably better to #define fss_compat_ioctl(...) EINVAL somewhere. We ought to sort out a way of making the compat code loadable - in which case this would need to be a real function call (possibly an indirect one). David -- David Laight: da...@l8s.co.uk