On Sun, Mar 18, 2012 at 09:00:54PM +0000, Christos Zoulas wrote: > In article <20120318191308.ga10...@britannica.bec.de>, > Joerg Sonnenberger <jo...@britannica.bec.de> wrote: > >On Sat, Mar 17, 2012 at 05:30:31PM -0400, Christos Zoulas wrote: > >> Module Name: src > >> Committed By: christos > >> Date: Sat Mar 17 21:30:30 UTC 2012 > >> > >> Modified Files: > >> src/sys/sys: types.h > >> > >> Log Message: > >> PR/44847: Jukka Ruohonen: blksize_t should be signed. > >> http://pubs.opengroup.org/onlinepubs/000095399/basedefs/sys/types.h.html > > > >I dislike the change. What is the justification for requiring this to be > >signed? There are good reasons for having it be unsigned, e.g. getting > >more efficient code by default. > > va_blocksize is signed (long) and most of the 360+ userland occurances > assume it is signed.
That doesn't say anything about why it should be signed. It is just another place where signed is used for no good reason. Joerg
