martin@ wrote: > Here is a patch that changes MAKEDEV to: > > - not include "{i,o,}pty" on any arch in the "all" target > - mount a ptyfs on top of a tmpfs /dev if the latter is created and > populated due to missing /dev/console by init > > Since our ptyfs implementation currently only allows a single instance, this > can not lead to double mounted ptyfs even if /etc/fstab contains another > instance. However, it will (of course) fail if mount_ptyfs is not available > or support for the filesystem is missing (non modular kernel w/o proper > option). > > What do you think?
Looks acceptable, but some thoughts: - MAKEDEV already has "makedir" command so isn't it better to use "makedir pts 755" as "ptm" entry does? Or just do "mkdev ptm"? - isn't it better to fallback to create compat ipty nodes if mount_ptyfs fails, so that we don't have to put tweaks into obsolete install floppies? (though it might cause inode shortage because a number of nodes is calculated before create_mfs_dev is called in makedev_main()) --- Izumi Tsutsui