On Jun 22, 8:58pm, dholland-sourcechan...@netbsd.org (David Holland) wrote: -- Subject: Re: CVS commit: src/external/bsd/cron/dist
| On Sun, Jun 22, 2014 at 04:53:50PM -0400, Christos Zoulas wrote: | > | > >Modified Files: | > | > > src/external/bsd/cron/dist: do_command.c | > | > > | > | > >Log Message: | > | > >Log some actual information on various failures, so you can tell | > | > >what happened. | > | > | > | > ??? This code is not used. We are using the LOGIN_CAP code. What are you | > | > trying to fix? | > | | > | Isn't it? (All of it?) I had a problem at one point (a few months | > | back, I think, it took me a while to remember to fetch the patch out | > | and commit it) that was printing a useless message, and I added some | > | extra information to diagnose it, and in the course of found a lot of | > | similar diagnostics and patched them all for completeness. | > | > All of it :-) | | The chdir one is outside of LOGIN_CAP. That's the one I hit, I think | because of nfs/nis issues, and I fixed the rest because they're all | the same. That's the only one. I would have fixed them by also printing the string that failed not just the user info. But that's better than before. | I think I was contemplating sending the patch upstream. (is that | worthwhile?) Go for it. We have a *lot* of other patches that should be sent upstream too. christos