Le 23/02/2015 14:51, Ryota Ozaki a écrit : > Hi, > > On Sun, Feb 22, 2015 at 11:55 PM, Maxime Villard <[email protected]> wrote: >> Module Name: src >> Committed By: maxv >> Date: Sun Feb 22 14:55:23 UTC 2015 >> >> Modified Files: >> src/sys/ufs/ext2fs: ext2fs_vfsops.c >> >> Log Message: >> Merge _sbcompute() and _sbcheck() into _sbfill(). >> >> In ext2fs_sbfill(), check more fields of the superblock, to prevent >> several kernel panics when mounting/unmounting a disk. > > This change seems to break ATF tests. > http://releng.netbsd.org/b5reports/amd64/commits-2015.02.html#end > > Could you check what happens? >
Ok, I've switched back to more "simple" checks. I tested my changes with a Linux-formatted disk, and fuzzed several times some fields. It did work. Thanks for pointing this out. > ozaki-r > >> >> >> To generate a diff of this commit: >> cvs rdiff -u -r1.188 -r1.189 src/sys/ufs/ext2fs/ext2fs_vfsops.c >> >> Please note that diffs are not public domain; they are subject to the >> copyright notices on the relevant files. >> >
