On Apr 29, 10:07pm, plu...@ogmig.net (Iain Hibbert) wrote: -- Subject: Re: CVS commit: src/sys/dev/bluetooth
| On Wed, 29 Apr 2015, Christos Zoulas wrote: | | > On Apr 29, 4:27pm, m...@m00nbsd.net (Maxime Villard) wrote: | > -- Subject: Re: CVS commit: src/sys/dev/bluetooth | > | > | You didn't test this change, nor did you test the five other fixes | > | you committed. | > | > I checked the code to the best of my ability; perhaps I missed something. | | by the way, the Brainy code scanner did not pick them up (perhaps it stops | at the first one?) but when I looked briefly at this code, there seem | other calls to bcsp_tx_unreliable_pkt() which also leak the mbuf on | failure, since if it fails it does not free it? Exactly, there are more problems. It would help if the original e-mail had less emotional context and more technical. christos
