On Dec 3,  6:54am, k...@munnari.oz.au (Robert Elz) wrote:
-- Subject: Re: CVS commit: src/sbin/gpt

|     Date:        Wed, 2 Dec 2015 17:41:08 -0500
|     From:        chris...@zoulas.com (Christos Zoulas)
|     Message-ID:  <20151202224108.9064b17f...@rebar.astron.com>
| 
|   | I observe data going to stdout because:
|   | static const char *outfile = "/dev/stdout";
| 
| Oh yes, OK, sorry - missed that.    It isn't a style I would use, so
| I wasn't expecting that.   I dislike assigning to a gobal var from a
| source that might come from anywhere ... in current invocation it is
| from the arg list, so isstable, but someone might add an interactive
| gpt mode, and then this method would break badly.

Yes, I am fixing those in the next pass (no static globals).

christos

Reply via email to