Hello Tetsuya and Christos,
On Tue, 7 Nov 2017 14:45:47 Tetsuya Isaki wrote: > nat@, (cc: christos@) > > With this change, vs(4) no longer works even if usemixer=0. > Please revert it, and don't break without public discussion. vs audio with the mixer enabled has been fixed in a follow up commit. The change was intended to benifit slow (antiquated) computers that may have trouble with the extra code in the audio path with mixing enabled. > > This is the 3rd time you broke vs(4). > You broke and I repaired. > You broke and I repaired. > I spent a lot of time this half year. The reason as to why vs audio does not work with usemixer=0 is that you decided to remove what you considered to be dead code (mulaw, alaw, unsigned linear filters). The time I've spent on audio/ossaudio/bluetooth audio has been at least two years non-stop and I will devote more time to it in future - so I think it's fair to say we've all spent a lot of time perfecting NetBSD. > > If you can not consider about supported devices (at least > devices which has active users), please don't touch audio. > Every time I make a change I test it with emulations of various computers, usb audio devices, all of the computers I own and bluetooth. Also an x68k emulation since x68k has been a problem with the changes. I think to hold the merits of what I done to audio to x68k's abilities to be unfair. I'm actively trying to innovate and to bring NetBSD's audio server into the 21 century whist still providing a solution for legacy systems we support. I hope to contine to work on audio in future - if there is an emmense objection from others I will stop audio completely and work on something else. NB: Since I've started to alter audio with regards to mixing and such, I've received at least 30 thank you emails from strangers and NetBSD users - The people we write NetBSD for. > Thanks, > --- > Tetsuya Isaki <is...@pastel-flower.jp / is...@netbsd.org> Best regards and I hope to collaborate with you on audio in future as it is a mutual interest. Nat > > At Tue, 7 Nov 2017 01:13:19 +0000, > > > Module Name: src > > Committed By: nat > > Date: Tue Nov 7 01:13:19 UTC 2017 > > > > Modified Files: > > src/sys/dev: audio.c audiovar.h > > > > Log Message: > > A sysctl is now available to disable the in kernel mixer. > > > > sysctl -w hw.hdafg0.usemixer=0 > > > > There currently is a problem draining the last block with the mixer > > disabled. I will fix this in a follow up commit. > > > > AFAIK there will be a problem wiht vs(4) on x68k with the mixer disabled > > as the filters for mulaw, alaw and unsigned linear have been removed post > > audio mixing changes. > > > > Documentation for this sysctl variable will be made to audio.4 in a > > follow up commit. > > > > Ok christos@. > > > > > > To generate a diff of this commit: > > cvs rdiff -u -r1.429 -r1.430 src/sys/dev/audio.c > > cvs rdiff -u -r1.66 -r1.67 src/sys/dev/audiovar.h
