On Sun, Dec 03, 2017 at 11:53:37PM +0100, Manuel Bouyer wrote: > On Sun, Dec 03, 2017 at 11:06:47AM -0800, bch wrote: > > ... > > /usr/src/sys/dev/acpi/wmi/wmi_dell.c: In function 'wmi_dell_action': > > /usr/src/sys/dev/acpi/wmi/wmi_dell.c:234:16: error: comparison between > > signed and unsigned integer expressions [-Werror=sign-compare] > > for (i = 0; i < __arraycount(wmi_dell_actions); i++) { > > ^ > > cc1: all warnings being treated as errors > > that's strange, I don't get it on my sources tree.
Odd that you wouldn't, but maybe it depends on whether you're building a kernel or something rumpity. > Would changing i to unsigned int fix the warning ? Yes. Provided of course that it doesn't break elsewhere that way :-) -- David A. Holland dholl...@netbsd.org