> Date: Thu, 29 Mar 2018 23:53:42 +0100 > From: Alexander Nasonov <al...@yandex.ru> > > m...@netbsd.org wrote: > > I seem to recall a discussion about wanting to avoid this type > > of commit message (hi dev-name), as it can be seen as excessively > > hostile. > > 'ok rmind@' would definitely be better than 'hi maxv@'. > > Hostile? I don't think so. I personally quite like it.
They mean different things. `hi dev@' means `FYI, dev@, you broke this, so I'm fixing it'. `ok dev@' means `dev@ reviewed and approved this change'. One connotation of `hi dev@' may be `dev@ is an idiot'; it can be offputting -- and it's not really necessary to call them out publicly. Sometimes dev@ has a rapport with the committer and will take it as good-natured, but a passive observer can't tell the difference between one colleague joshing another and someone saying `you're an idiot and I cleaned up your mess'.