In article <20180708092258.ga13...@britannica.bec.de>, Joerg Sonnenberger <jo...@bec.de> wrote: >On Sun, Jul 08, 2018 at 06:21:42AM +0000, Paul Goyette wrote: >> Module Name: src >> Committed By: pgoyette >> Date: Sun Jul 8 06:21:42 UTC 2018 >> >> Modified Files: >> src/sys/sys: types.h >> >> Log Message: >> Use a different, type-insensitive idiom for CLR(). >> >> As discussed on IRC and proposed by dholland@, the existing idiom is >> type-sensitive, and will likely fail silently when the flags variable >> is a 64-bit type. >> >> No functional change intended. If anything breaks, it was probably >> already broken. > >This is much worse, since it now will evaluate the expression twice. >Please do not just change macros like this without a proper discussion >on the mailing lists.
Yes, the double evaluation is a show-stopper, please revert. christos
