On 20/10/2018 11:24, Jared McNeill wrote:
On Sat, 20 Oct 2018, Ryo Shimizu wrote:
I think the dts should be fixed rather than #ifdef __arm__
I agree that we need to change dts to eliminate 32bit enable method from
the dtb for 64bit. However, it is also strange that enable-method code
for 32bit ARM remains in the 64bit binary as well.
I don't think the dts should be changed. This lets use share a dtb
between 32- and 64-bit kernels. The brcm,bcm2836-smp enable-method is
documented as being supported only in 32-bit mode:
https://www.kernel.org/doc/Documentation/devicetree/bindings/arm/cpus.txt
Can't see enable-method as property of cpus node in the standard
bindings. Surely, bcm2837.dtsi is using non-standard bindings
http://src.illumos.org/source/xref/netbsd-src/sys/external/gpl2/dts/dist/arch/arm/boot/dts/bcm2837.dtsi#30
30 cpus: cpus {
31 #address-cells = <1>;
32 #size-cells = <0>;
33 enable-method = "brcm,bcm2836-smp"; // for ARM 32-bit
Nick
