In article <20190627195610.c4be7f...@cvs.netbsd.org>,
Maxime Villard <source-changes-d@NetBSD.org> wrote:
>-=-=-=-=-=-
>
>Module Name:   src
>Committed By:  maxv
>Date:          Thu Jun 27 19:56:10 UTC 2019
>
>Modified Files:
>       src/sys/kern: kern_exec.c
>
>Log Message:
>Fix this fucking shit once and for all, for fuck's sake.

This is exactly what I was referring to about poor communication
in my previous replay. A better commit message would have been:

    Actually set the error returned. The previous commit made things worse
    because the function would return a 0 and free the pathbuf crashing the
    kernel.

This would have been informative, non-insulting and probably would have
taught the author to be more careful in the future. 

Best,

christos

Reply via email to