Module Name:    src
Committed By:   christos
Date:           Tue Jul 23 09:47:16 UTC 2019

Modified Files:
        src/lib/libedit: chared.c

Log Message:
PR/54400: S�ren Tempel: out-of-bounds read in libedit c_delbefore


To generate a diff of this commit:
cvs rdiff -u -r1.57 -r1.58 src/lib/libedit/chared.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/lib/libedit/chared.c
diff -u src/lib/libedit/chared.c:1.57 src/lib/libedit/chared.c:1.58
--- src/lib/libedit/chared.c:1.57	Wed Oct 11 02:49:03 2017
+++ src/lib/libedit/chared.c	Tue Jul 23 05:47:16 2019
@@ -1,4 +1,4 @@
-/*	$NetBSD: chared.c,v 1.57 2017/10/11 06:49:03 abhinav Exp $	*/
+/*	$NetBSD: chared.c,v 1.58 2019/07/23 09:47:16 christos Exp $	*/
 
 /*-
  * Copyright (c) 1992, 1993
@@ -37,7 +37,7 @@
 #if 0
 static char sccsid[] = "@(#)chared.c	8.1 (Berkeley) 6/4/93";
 #else
-__RCSID("$NetBSD: chared.c,v 1.57 2017/10/11 06:49:03 abhinav Exp $");
+__RCSID("$NetBSD: chared.c,v 1.58 2019/07/23 09:47:16 christos Exp $");
 #endif
 #endif /* not lint && not SCCSID */
 
@@ -174,7 +174,7 @@ c_delbefore(EditLine *el, int num)
 		wchar_t *cp;
 
 		for (cp = el->el_line.cursor - num;
-		    cp <= el->el_line.lastchar;
+		    &cp[num] <= el->el_line.lastchar;
 		    cp++)
 			*cp = cp[num];
 

Reply via email to